This repository was archived by the owner on Aug 22, 2023. It is now read-only.
Make @oclif/config a prod dependency#60
Closed
ersinakinci wants to merge 1 commit into
Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
==========================================
- Coverage 68.07% 67.28% -0.79%
==========================================
Files 5 5
Lines 166 162 -4
Branches 35 35
==========================================
- Hits 113 109 -4
Misses 33 33
Partials 20 20
Continue to review full report at Codecov.
|
Author
|
Not sure why code coverage went down...? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes
@oclif/configa prod dependency rather than a dev dependency. The motivation is to fix monorepo projects whose dependencies are managed by pnpm, since pnpm isolates each monorepo project's dependency's dependencies.Context: when using yarn or npm,
@oclif/configis visible to@oclif/commandbecause it's a prod dependency foroclif(i.e., https://github.com/oclif/oclif/blob/master/package.json#L10) andnode_moduleshas a flat structure. However, with pnpm monorepos,oclif's dependencies and@oclif/command's dependencies are isolated from each other, and so@oclif/configisn't visible to@oclif/command.I believe that this behavior is not only helpful for those of us using pnpm, it also implements the correct behavior since
@oclif/configis called at runtime and should therefore be properly considered a prod dependency.Fixes #59