Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: version 3 #387

Merged
merged 8 commits into from
Sep 28, 2023
Merged

feat!: version 3 #387

merged 8 commits into from
Sep 28, 2023

Conversation

mdonnalley
Copy link
Contributor

@mdonnalley mdonnalley commented Sep 26, 2023 •
edited
Loading

BREAKING CHANGE: node 18+, fancy-test v3

  • Support for node 18+
  • Bump linting libraries
  • Uses fancy-test v3 (see feat!: v3 fancy-test#333), which changes how stubs are defined:

v2:

test
  .stub(os, 'platform', () => 'foobar')

v3:

test
  .stub(os, 'platform', stub => stub.returns('foobar'))

@git2gus
Copy link

git2gus bot commented Sep 26, 2023

This issue has been linked to a new work item: W-14188310

mshanemc
mshanemc approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@mshanemc mshanemc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core v3 is already using a prerelease of it. That's QA.

@mshanemc mshanemc merged commit dd9a700 into main Sep 28, 2023
5 checks passed
@mshanemc mshanemc deleted the mdonnalley/core-v3 branch September 28, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshanemc mshanemc mshanemc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdonnalley @mshanemc @svc-cli-bot