Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update rome config and example #54

Merged
merged 6 commits into from
Nov 20, 2022
Merged

Conversation

drieshooghe
Copy link
Member

@drieshooghe drieshooghe commented Nov 20, 2022

  • 🔨 update rome config
  • ✨ if the dynamodb collections exist, skip the setup
  • ✨ update example

This PR

  • fixes the Rome config to the new format
  • uses dynamodb in the example
  • doesn't try to create event and snapshot collections if they already exist

@codecov
Copy link

codecov bot commented Nov 20, 2022

Codecov Report

Merging #54 (e0dab65) into master (6f5966f) will decrease coverage by 0.32%.
The diff coverage is 73.91%.

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
- Coverage   92.32%   92.00%   -0.33%     
==========================================
  Files          89       89              
  Lines        1355     1375      +20     
  Branches      269      277       +8     
==========================================
+ Hits         1251     1265      +14     
- Misses        100      106       +6     
  Partials        4        4              
Impacted Files Coverage Δ
lib/integration/event-store/mongodb.event-store.ts 97.33% <66.66%> (-1.28%) ⬇️
...tegration/snapshot-store/mongodb.snapshot-store.ts 98.18% <66.66%> (-0.89%) ⬇️
...ib/integration/event-store/dynamodb.event-store.ts 95.04% <75.00%> (-1.76%) ⬇️
...egration/snapshot-store/dynamodb.snapshot-store.ts 96.50% <75.00%> (-1.30%) ⬇️
lib/models/aggregate-root.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@drieshooghe drieshooghe merged commit a3f7305 into master Nov 20, 2022
@drieshooghe drieshooghe deleted the update-rome-config-and-example branch November 20, 2022 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant