Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert & Save buttons for colors get clipped out in ShowStyleEditor demo #1211

Closed
geneotech opened this issue Jul 3, 2017 · 2 comments
Closed
Labels

Comments

@geneotech
Copy link

geneotech commented Jul 3, 2017

I'm running imgui_examples_msvc2010:

2017-07-03_17-00-32

Revert button gets clipped, and it is completely impossible to save some of the options when the ref argument is non-null. Resizing the window does not help.

Perhaps a good idea would be to decrease widths of the R, G, B, A value bars?

@ocornut
Copy link
Owner

ocornut commented Jul 9, 2017

Yeah it's a bit crappy. In a real application I would use icons and put them before the label, fixed size, greyed out or hidden when unavailable, but imgui doesn't rely on icons-font at the moment.

I'll put that on hold for now because I may revamp the styling system.

@ocornut
Copy link
Owner

ocornut commented Nov 18, 2017

@geneotech : I made some improvements to the style editor and among other things this is now fixed.

I also added a comment in that code explaining how in this case I would suggest use Icons from an icon font (but we can't in the demo code because we don't have guarantee of which fonts are loaded), so hopefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants