Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang warnings in v1.42 #265

Closed
extrawurst opened this issue Jul 8, 2015 · 2 comments
Closed

clang warnings in v1.42 #265

extrawurst opened this issue Jul 8, 2015 · 2 comments

Comments

@extrawurst
Copy link
Contributor

c++ -I/usr/local/include -Wall -c -o ../imgui/imgui.o ../imgui/imgui.cpp
../imgui/imgui.cpp:10867:33: warning: cast to 'void *' from smaller integer type 'int' [-Wint-to-void-pointer-cast]
                ImGui::TreePush((void*)i);
                                ^
../imgui/imgui.cpp:10908:37: warning: cast to 'void *' from smaller integer type 'int' [-Wint-to-void-pointer-cast]
                if (ImGui::TreeNode((void*)i, "Child %d", i))
                                    ^
2 warnings generated.
@ocornut ocornut closed this as completed in f4aae6b Jul 8, 2015
ocornut added a commit that referenced this issue Jul 8, 2015
Fix minor clang-x64 warnings (fixes #265)
ocornut added a commit that referenced this issue Jul 8, 2015
@ocornut
Copy link
Owner

ocornut commented Jul 8, 2015

Ah actually they were already fixed in the aa branch via disabling those warnings.

I recall there was a TreeNode(int) early on prior to 1.0 release I can't remember why I removed it, if I should felt it was easy enough to cast to (void*) or if it was because it created type inference conflict at the call site.

@extrawurst
Copy link
Contributor Author

ok disabling is fine by me ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants