Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash while resizing docked windows when one of the windows is not visible. #3328

Closed
Myszkoj opened this issue Jun 30, 2020 · 2 comments
Closed

Comments

@Myszkoj
Copy link

Myszkoj commented Jun 30, 2020

Hi! I keep getting this assertion:
crash_006

I made this example to show when this happes:
docking problem

At first i thought i messed up something in the code, but i managed to reproduce this crash in your Demo -> Examples -> Documents:
crash_007
crash_008

In this example I have docked 3 windows, one after another (Eggplant, Lettuce, Carrot), then I closed the Lettuce window and moved splitter towards the Eggplant, after this I reopened the Lettuce window and the same crash appeared again.

I downloaded imgui-docking.zip on 24th of June 2020.

@ocornut
Copy link
Owner

ocornut commented Jun 30, 2020

Thanks for the report, confirmed.
I have I have a fix/branch somewhere where I was working on it, will investigate.

ocornut added a commit that referenced this issue Jun 30, 2020
…om for nodes + do not hold on WantLockSizeOnce forever (#3328)

(Ensure if the fact that WantLockSizeOnce was kept when only 1 child is visible was desired/desirable)
@ocornut
Copy link
Owner

ocornut commented Jun 30, 2020

Pushed a fix I had in another branch.
Since there's not enough space for both windows in that small node it'll look weird but it's easy to recover it by resizing.

I'm working on toolbar usage patterns which requires nodes pushing back for the size they need, and it may lead further related changes.

@ocornut ocornut closed this as completed Jun 30, 2020
Mernion pushed a commit to Mernion/imgui that referenced this issue Aug 3, 2020
…om for nodes + do not hold on WantLockSizeOnce forever (ocornut#3328)

(Ensure if the fact that WantLockSizeOnce was kept when only 1 child is visible was desired/desirable)
Mernion pushed a commit to Mernion/imgui that referenced this issue Aug 3, 2020
…om for nodes + do not hold on WantLockSizeOnce forever (ocornut#3328)

(Ensure if the fact that WantLockSizeOnce was kept when only 1 child is visible was desired/desirable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants