Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tthe background color of popup modal is iincorrect grey. #4845

Closed
AllenDang opened this issue Dec 31, 2021 · 6 comments
Closed

Tthe background color of popup modal is iincorrect grey. #4845

AllenDang opened this issue Dec 31, 2021 · 6 comments
Labels
backends bug

Comments

@AllenDang
Copy link

Version/Branch of Dear ImGui:

Version: 1.86
Branch: master

Back-end/Renderer/Compiler/OS

Back-ends: imgui_impl_opengl3.cpp + imgui_impl_glfw.cpp

My Issue/Question:

Tthe background of popup modal is iincorrect grey. I can repo it with imgui_demo.cpp.

Screenshots/Video

bug
@ocornut
Copy link
Owner

ocornut commented Dec 31, 2021

Are you sure you are using imgui_impl_opengl3.cpp ? If you are using an old or other backend try updating, there was a bug in some old backends.

@AllenDang
Copy link
Author

@ocornut I'm using the golang version backend, I'll check them line-by-line. Thanks.

@ocornut
Copy link
Owner

ocornut commented Dec 31, 2021

To clarify, this happens if the renderer backend doesn’t honor the IdxOffset field properly and tries to compute it itself.

See last version’s fix for GL2 and Allegro backends: c80e8b9

@AllenDang
Copy link
Author

@ocornut Thanks for giving me the clue. I got it fixed.

@ocornut ocornut mentioned this issue Jan 4, 2022
Closed
@ocornut ocornut added the bug label Jan 4, 2022
@pezcode
Copy link

pezcode commented Jan 5, 2022

To clarify, this happens if the renderer backend doesn’t honor the IdxOffset field properly and tries to compute it itself.

The comment for IdxOffset still says:

// Start offset in index buffer. Always equal to sum of ElemCount drawn so far.

Should that be changed then, or am I misinterpreting it?

@ocornut
Copy link
Owner

ocornut commented Jan 5, 2022 via email

ocornut added a commit that referenced this issue Jan 5, 2022
@ocornut
Fix IdxBuffer related comments. (#4845, #4863)
04bc0b0
This was referenced Jan 10, 2022
Closed
Closed
@jvannugteren jvannugteren mentioned this issue Jan 11, 2022
Closed
pezcode added a commit to pezcode/magnum-integration that referenced this issue Jan 12, 2022
@pezcode
ImGuiIntegration: use ImDrawCmd::IdxOffset
b471f2c 
Manually calculating the index buffer offset isn't correct (despite the comment for IdxOffset indicating otherwise). This surfaced with changes in v1.86 under certain circumstances, e.g. stacked modals. See ocornut/imgui#4845.
@oledfish oledfish mentioned this issue Jan 18, 2022
Merged
mosra pushed a commit to mosra/magnum-integration that referenced this issue Jan 31, 2022
@pezcode @mosra
ImGuiIntegration: use ImDrawCmd::IdxOffset
3e7b175 
Manually calculating the index buffer offset isn't correct (despite the
comment for IdxOffset indicating otherwise). This surfaced with changes
in v1.86 under certain circumstances, e.g. stacked modals. See
ocornut/imgui#4845.
@bvigario bvigario mentioned this issue Mar 11, 2022
Merged
mellinoe pushed a commit to veldrid/veldrid that referenced this issue Mar 16, 2022
@bvigario
fix IdxOffset field (#442)
2282c5c 
ocornut/imgui#4845
ThiconZ added a commit to themeldingwars/ImTool that referenced this issue Apr 5, 2022
@ThiconZ
Update ImGuiController to latest Veldrid design
35a01a3 
[ImGui] Remove unnecessary allocation in ImGuiRenderer.cs.

Fix XML comment in ImGuiRenderer.cs

Fix swapped right/middle mouse button detection in ImGuiRenderer.

[Vulkan] Respect Shader.EntryPoint when creating a Pipeline.

Allow ImGuiRenderer's font texture to be recreated after startup.

[ImGui] Dispose previous font-related resources before creating new ones.

[ImGui] Remove explicit font TextureView.

[ImGui] Add RemoveImGuiBinding for removing cached image bindings.

Fix variable naming in ImGuiRenderer.

[Vulkan] Reference count more resources.

Change ImGui update method

fix IdxOffset field (#442) ocornut/imgui#4845
@ocornut ocornut mentioned this issue Jun 17, 2022
Closed
azeno added a commit to vvvv/VL.ImGui that referenced this issue Jun 28, 2022
@azeno
Use proper index offset for drawing (still doesn't fix the modal wind…
f989abd 
…ow drawing glitch)

But still it should fix something (see ocornut/imgui#4845 (comment))
@ocornut ocornut mentioned this issue Jun 30, 2022
Closed
@RedImp1470 RedImp1470 mentioned this issue Jul 14, 2022
Closed
@tlf30 tlf30 mentioned this issue Jul 21, 2022
Closed
@ocornut ocornut mentioned this issue Aug 1, 2022
Closed
JoelLinn added a commit to JoelLinn/xenia that referenced this issue Sep 22, 2022
@JoelLinn
[ImGui] Use ImDrawCmd::IdxOffset field
fdbd9df 
ocornut/imgui@c80e8b9
ocornut/imgui#4845 (comment)
JoelLinn added a commit to JoelLinn/xenia that referenced this issue Sep 22, 2022
@JoelLinn
[ImGui] Use ImDrawCmd::IdxOffset field
e66a696 
ocornut/imgui@c80e8b9
ocornut/imgui#4845 (comment)
JoelLinn added a commit to JoelLinn/xenia that referenced this issue Nov 20, 2022
@JoelLinn
[ImGui] Use ImDrawCmd::IdxOffset field
6305c62 
ocornut/imgui@c80e8b9
ocornut/imgui#4845 (comment)
gibbed pushed a commit to xenia-project/xenia that referenced this issue Dec 28, 2022
@JoelLinn @gibbed
[ImGui] Use ImDrawCmd::IdxOffset field
7877331 
ocornut/imgui@c80e8b9
ocornut/imgui#4845 (comment)
@mattj1 mattj1 mentioned this issue Feb 25, 2023
Merged
@dimateos dimateos mentioned this issue Apr 13, 2023
Closed
@kkawachi kkawachi mentioned this issue Dec 3, 2023
Merged
@Aman-Anas Aman-Anas mentioned this issue Dec 17, 2023
Closed
@pthom pthom mentioned this issue Dec 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backends bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AllenDang @pezcode @ocornut