Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConfigDockingWithShift for undocking #6823

Closed
sonoro1234 opened this issue Sep 14, 2023 · 3 comments
Closed

ConfigDockingWithShift for undocking #6823

sonoro1234 opened this issue Sep 14, 2023 · 3 comments
Labels
docking

Comments

@sonoro1234
Copy link

Version/Branch of Dear ImGui:

Version: 1.89
Branch: docking

Back-end/Renderer/Compiler/OS

cimgui
Back-ends: imgui_impl_OpenGL3.cpp + imgui_impl_glfw.cpp
Compiler : gcc
Operating System: windows 10

My Issue/Question:

When ConfigDockingWithShift is set to true, pressing shift is necessary for docking but not for undocking.
@ocornut ocornut changed the title ConfigDockingWithShift not working. ConfigDockingWithShift for undocking Sep 15, 2023
@ocornut
Copy link
Owner

ocornut commented Sep 15, 2023

Hello Victor,
This is as designed. The purpose of the option is to reduce visual clutter when moving windows around, but I don't see a point preventing a move/undock. Why do you think it would be desirable?

@sonoro1234
Copy link
Author

sonoro1234 commented Sep 15, 2023 •
edited
Loading

imgui/imgui.h

Line 824 in 72dbe45

// - When io.ConfigDockingWithShift == true, you instead need to hold SHIFT to _enable_ docking/undocking.

Seems to say this: you instead need to hold SHIFT to enable docking/undocking.
The reason would be to lock docking: dock operations disabled unless user press SHIFT.

ocornut added a commit that referenced this issue Sep 15, 2023
@ocornut
Docking: Fixed ImGuiDockNodeFlags_NoDocking not preventing split + Co…
53d68cd 
…mments. Removed misleading shared/local identicators. (#6823, #2999)

NoDocking not marked as saved (it never was). Removed unused ImGuiDockNodeFlags_LocalFlagsMask_.
ocornut added a commit that referenced this issue Sep 15, 2023
@ocornut
Docking: Internals: added ImGuiDockNodeFlags_NoUndocking. (#2999, #6823…
bbaf673 
…, #6780)
ocornut added a commit that referenced this issue Sep 15, 2023
@ocornut
Docking: Comments. Removed misleading shared/local identicators. (#6823…
14f8b76 
…, #2999)

NoDocking not marked as saved (it never was). Removed unused ImGuiDockNodeFlags_LocalFlagsMask_.
ocornut added a commit that referenced this issue Sep 15, 2023
@ocornut
Docking: Internals: added ImGuiDockNodeFlags_NoUndocking. (#2999, #6823…
1612813 
…, #6780)
ocornut added a commit that referenced this issue Sep 18, 2023
@ocornut
Docking: made "ImGuiDockNodeFlags_NoDocking" a combination of all oth…
f693c3d 
…ers ImGuiDockNodeFlags_NoDockingXXX flags. (#2999, #6823, #6780, #3492)
ocornut added a commit that referenced this issue Sep 18, 2023
@ocornut
Docking: made ImGuiDockNodeFlags_NoUndocking public. (#2999, #6823, #…
afd0d3f 
…6780, #3492)

Amend 1612813.
@ocornut
Copy link
Owner

ocornut commented Sep 18, 2023

I have now added a ImGuiDockNodeFlags_NoUndocking flag which may be used on e.g. a DockSpace() or a programmatically created node to lock its content.
Moving the rest of this conversation to #6780

@ocornut ocornut closed this as completed Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docking
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sonoro1234 @ocornut