New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fonts stored in base85 can contain trigraphs. #839
Comments
…as a trigraph but consistent with encoder (#839)
Nice catch. Who ever remembers about trigraphs nowadays? I'm surprised they affect string literals to be honest, Wikipedia is unclear:
Then immediately following
Changing the encoding isn't desirable as it would break already encoded data. Instead I added escape characters when there are pairs of ?? as suggested by the wikipedia entry: Does that works for you? I didn't test with an old compiler. Do you have problems with digraphs as well? ( |
I think c++11 and newer remove or disable them by default |
Yes. |
I can confirm that the submitted changes resolve the issue. Surprisingly I stumbled onto it when using the latest https://github.com/kripken/emscripten-fastcomp-clang . I don't plan on using either trigraphs or diagraphs in any of my projects so I'll be a user of "-Werror=trigraphs" from now on. Thanks for the help and for this amazing library. |
When using
the result ends up containing trigraphs like ??( witch will end up replaced to other characters on some build setups.
It might be worth adjusting or changing the base85 algorithm to something like https://github.com/maksverver/base85
Edit:
The text was updated successfully, but these errors were encountered: