IsItemActive() always return false after calling InputFloat()

[thedmd]

IsItemActive() always return false after calling ImGui::InputFloat(...).

InputFloat is implemented using InputScalerEx which wraps InputText in group. EndGroup() modify window->DC.LastItemId and in g.ActiveId == window->DC.LastItemId in IsItemActive() is always false.

Is this a real issue or expected behavior?

static float value = 0.0f;
ImGui::InputFloat("Dummy", &value);
const bool isActive = ImGui::IsItemActive();
printf("Is Active: %s\n", isActive ? true : false);

[ocornut]

Definitively a bug, needs to be fixed!

[thedmd]

This is possible workaround. But IsItemActive seems to lag a frame.

@@ -8306,7 +8306,9 @@ bool ImGui::InputScalarEx(const char* label, ImGuiDataType data_type, void* data
         RenderText(ImVec2(window->DC.CursorPos.x, window->DC.CursorPos.y + style.FramePadding.y), label);
         ItemSize(label_size, style.FramePadding.y);
     }
+    auto lastItemId = window->DC.LastItemId;
     EndGroup();
+    window->DC.LastItemId = lastItemId;

     return value_changed;
 }

[ocornut]

I don't see any reason for a lag there. IsItemActive() will test those values directly. Did you confirm the lag?

However this need a little adjustment/work-around to also function when the Steps buttons are enabled.

[ocornut]

I have applied the more general fix where if any item within the group is the active id, then IsItemActive() after EndGroup() will report true. This fix similar issue for other widgets using BeginGroup(), and allow removal of similar workaround code in InputTextMultiline().

Repro

ImGui::Begin("Bug #840");
static float value = 0.0f;
ImGui::InputFloat("Dummy", &value, 1);
ImGui::Text("IsActive: %d", ImGui::IsItemActive());
//ImGui::Text("ActiveID: %08X, LastActiveID: %08X", GImGui->ActiveId, GImGui->CurrentWindow->DC.LastItemId);
ImGui::End();

The lag is a different issue, if you are talking about

printf("IsActive: %d, MouseDown[0]: %d\n", ImGui::IsItemActive(), ImGui::IsMouseClicked(0));
//
IsActive: 0, MouseDown[0]: 0
IsActive: 0, MouseDown[0]: 1
IsActive: 1, MouseDown[0]: 0

Looking into that.

[ocornut]

Fixed the other issue.

[thedmd]

@ocornut Thank you!