Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples/example_win32_opengl2 #2359

Closed
wants to merge 1 commit into from

Conversation

podsvirov
Copy link
Contributor

Standalone example application for Win32 + WGL + OpenGL2, using legacy fixed pipeline.

Standalone example application for Win32 + WGL + OpenGL2,
using legacy fixed pipeline
@ocornut
Copy link
Owner

ocornut commented Feb 19, 2019

Hello @podsvirov, have you looked at #1553 ? (check the patch in the comments at the end).

Your code is simpler so I am interested in it. Presumably partly because it is using old OpenGL, partly some of the writing code (filling PIXELFORMATDESCRIPTOR you way you do it is easier).
The issue I had with #1553 is that new viewports would flicker (when using multi-viewports). If your doesn't have this problem or if the problem could be solved for the other PR it'd be good.

What do you use this for?
I've been hesitant to provide this because this is probably a path for lot of people adopting obsolete standards and asking for support. Regular backends are tedious enough :(

@podsvirov
Copy link
Contributor Author

podsvirov commented Feb 19, 2019

Hello @ocornut, the @podgorskiy account it's not a me, becouse my account is @podsvirov.

I have not tested it for multi-vieports and will try.

What do you use this for?

I think, that this can be used in education to quick start when learning computer graphics on Windows operation systems. And then learning more effictive and cross-platform solutions.

@ocornut
Copy link
Owner

ocornut commented Feb 19, 2019

becouse my account is @podsvirov.

Sorry for the typo (bad completion! edited the message now)

I think, that this can be used in education to quick start when learning computer graphics on Windows operation systems. And then learning more affictive and cross-platform solutions.

It seem backward to me to be teaching Win32 + legacy OpenGL when there are so many other ways. I'm asking because I need to protect myself from unnecessary support requests...
(The raw win32 examples are useful/necessary for me mainly because it's not trivial to wire them for multi-viewports.)

@podsvirov
Copy link
Contributor Author

From #1553:

One possible idea is to merge your code ... in master and specifically NOT attempt to support multi-viewport in this example.

May be for this PR too.

@ocornut
Copy link
Owner

ocornut commented Feb 21, 2019

May be for this PR too.

Actually I realized that the main value for a raw win32 example is to provide the multi-viewport implementation (because it is not obvious / trivial how to do it currently).

@ocornut ocornut force-pushed the master branch 2 times, most recently from 0c1e5bd to bb6a60b Compare August 27, 2021 19:10
@ocornut ocornut force-pushed the master branch 2 times, most recently from 8b83e0a to d735066 Compare December 13, 2021 11:31
@ocornut ocornut force-pushed the master branch 2 times, most recently from b3b85d8 to 0755767 Compare January 17, 2022 14:21
@ocornut ocornut force-pushed the master branch 3 times, most recently from c817acb to 8d39063 Compare February 15, 2022 16:25
ocornut pushed a commit that referenced this pull request Apr 19, 2023
…2772, #2600, #2359, #2022, #1553)

Removed mulit-viewpot stuff in this commit on master, will be re-added separately.
@ocornut
Copy link
Owner

ocornut commented Apr 19, 2023

Closed/solved, see #3218 (comment)

@ocornut ocornut closed this Apr 19, 2023
kjblanchard pushed a commit to kjblanchard/imgui that referenced this pull request May 5, 2023
 and ocornut#6086, ocornut#2772, ocornut#2600, ocornut#2359, ocornut#2022, ocornut#1553)

Removed mulit-viewpot stuff in this commit on master, will be re-added separately.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants