Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ImGui_ImplSDL2_InitForD3D() #2482

Closed
wants to merge 4 commits into from

Conversation

josiahmanson
Copy link
Contributor

This is a trivial change to add the function ImGui_ImplSDL2_InitForD3D() to the SDL platform. It can be useful to use SDL with D3D as a rendering backend, because SDL has a variety of other platform interfaces like input handling, etc.

Add ImGui_ImplSDL2_InitForD3D
Add ImGui_ImplSDL2_InitForD3D
oops deleted parameter SDL_Window* window
opps accidentally deleted SDL_Window* window
@ocornut
Copy link
Owner

ocornut commented Jun 12, 2019

Hello @josiahmanson ,
Ideally I would like an example_sdl_directxXX/ project that implemented this and also worked in the docking branch with multi-viewports enabled.

Linking to #2612

For multi-viewport, I think we should do something like in this commit:

yaz0r@bbe0eb9

Instead of adding a function I would just add a new field in ImGuiViewport*, e.g. adding void* PlatformHandleRaw next to void *PlatformHandle.

I can handle the design and change for multi-viewports if there is a PR for the basic example working in master.

@yaz0r
Copy link
Contributor

yaz0r commented Jun 14, 2019

@ocornut Still need to do a proper PR for this. I will try to get that done over the weekend.

@yaz0r yaz0r mentioned this pull request Jun 16, 2019
@ocornut
Copy link
Owner

ocornut commented Jun 18, 2019

This is now merged as part of #2632, thanks both!

@ocornut ocornut closed this Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants