Disable format checks when using stb_sprintf.h #2954
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
STB sprintf allows extra formats like %b or %$d. If ImGui is configured to use STB sprintf, it generates warnings with GCC and clang when using such formats because it keeps applying default printf-style warnings. This commit disables printf-style warnings when using STB sprintf. Since the printf-style warnings are defined in imgui.h based on the compiler, IMGUI_USE_STB_SPRINTF can't just be defined in the cpp file anymore and it's been moved as a proper config in imconfig.h.
loicmolinari
force-pushed
the
imgui-use-stb-sprintf-format-fix
branch
from
3e57da7
to
6d23bad
Compare
|
This is merged now, thank you! |
ocornut
pushed a commit
that referenced
this pull request
Mar 13, 2022
sergeyn
pushed a commit
to sergeyn/imgui
that referenced
this pull request
Mar 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STB sprintf allows extra formats like %b or %$d. If ImGui is configured
to use STB sprintf, it generates warnings with GCC and clang when using
such formats because it keeps applying default printf-style warnings.
This commit disables printf-style warnings when using STB sprintf.
Since the printf-style warnings are defined in imgui.h based on the
compiler, IMGUI_USE_STB_SPRINTF can't just be defined in the cpp file
anymore and it's been moved as a proper config in imconfig.h.