Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VtxOffset offset related fix (fixes blown up triangles on the screen) #3232

Closed
wants to merge 3 commits into from
Closed

VtxOffset offset related fix (fixes blown up triangles on the screen) #3232

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8687847
fixes triangle mess on the screen due to VtxOffset getting desynchron…
sergeyn May 15, 2020
a96a9c5
tabs to 4chars
sergeyn Jun 3, 2020
0ad81bb
added braces
sergeyn Jun 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions imgui_draw.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,9 +462,17 @@ void ImDrawList::UpdateClipRect()
// Try to merge with previous command if it matches, else use current command
ImDrawCmd* prev_cmd = CmdBuffer.Size > 1 ? curr_cmd - 1 : NULL;
if (curr_cmd->ElemCount == 0 && prev_cmd && memcmp(&prev_cmd->ClipRect, &curr_clip_rect, sizeof(ImVec4)) == 0 && prev_cmd->TextureId == GetCurrentTextureId() && prev_cmd->UserCallback == NULL)
{
CmdBuffer.pop_back();

//The command being popped may have triggered VtxOffset update (and _VtxCurrentIdx reset - see above AddDrawCmd), restore it here to avoid triangle mess on the screen
_VtxCurrentOffset = prev_cmd->VtxOffset;
_VtxCurrentIdx = VtxBuffer.size() - prev_cmd->VtxOffset;
}
else
{
curr_cmd->ClipRect = curr_clip_rect;
}
}

void ImDrawList::UpdateTextureID()
Expand Down