Fixed VkResult Error on macOS VulkanSDK 1.3.216 #6172
Closed
+44
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added function is_instance_extension_enabled() to check if instance functions are enabled. Helped by adding the enumeration extension
|
It turns out that your PR still breaks debug build (with IMGUI_VULKAN_DEBUG_REPORT) |
|
Happy that I could help, even if it wasn't much |
kjblanchard
pushed a commit
to kjblanchard/imgui
that referenced
this pull request
May 5, 2023
…dation layer errors. (ocornut#6109, ocornut#6172, ocornut#6101) Enable VK_KHR_GET_PHYSICAL_DEVICE_PROPERTIES_2_EXTENSION_NAME, VK_KHR_PORTABILITY_ENUMERATION_EXTENSION_NAME, VK_INSTANCE_CREATE_ENUMERATE_PORTABILITY_BIT_KHR
kjblanchard
pushed a commit
to kjblanchard/imgui
that referenced
this pull request
May 5, 2023
…o fVK_KHR_PORTABILITY_SUBSET_EXTENSION_NAME. (ocornut#6109, ocornut#6172, ocornut#6101)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@omar, @zao, @wolfpld I accidentally closed last PR. Here is the update version of #6109