Backends: add glBindSampler for GL ES 3.0 #6375
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visual Pinball uses ImGui to display it's Live UI.
While working on the cross platform port, we were getting a random flicker anytime the Live UI was visible on Android, iOS, and tvOS. The versions all use GL ES 3.0.
After using RenderDoc, we noticed the sampler was different between both frames.
glBindSampler
is supported on GL ES 3.0+.I've updated the code to enable
IMGUI_IMPL_OPENGL_MAY_HAVE_BIND_SAMPLER
when GL ES 3, and then handle it whenIMGUI_IMPL_OPENGL_ES3
This PR can be reworked accordingly as I wasn't sure how to check for ES in
bd->GlVersion