Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keymap and names for F13-F24 #6891

Closed
wants to merge 3 commits into from

Conversation

Kaldaien
Copy link
Contributor

@Kaldaien Kaldaien commented Oct 3, 2023

We need F13-F15 for our debug functionality in Special K, I was surprised after updating to modern ImGui (from a version ~2018), that F13-F24 aren't even in the new keymap system.

This is a simple fix that adds enumerated values and mapped names for these additional keys. I'd like to see it mainstreamed rather than projects such as NVIDIA Streamline/Reflex that use these infrequently used keys having to modify ImGui code directly.

@PathogenDavid
Copy link
Contributor

Support for these should also be added to the various platform backends.

@ocornut
Copy link
Owner

ocornut commented Oct 4, 2023

Hello,
Thanks for the PR. Yes, it would be good to add support for those keys for all backends where they exist.

@ocornut
Copy link
Owner

ocornut commented Oct 5, 2023

I have merged your commit as 73346e4 + added support in GLFW, SDL2, SDL3, Win32, OSX backends with b0758c8.

@ocornut ocornut closed this Oct 5, 2023
@zao
Copy link

zao commented Oct 5, 2023

@ocornut There seems to be a stray (debug?) printf in the win32 implementation:

printf("vk = %X -> key %d, scancode %d\n", vk, key, scancode);

@ocornut
Copy link
Owner

ocornut commented Oct 5, 2023

Amend with 7bbd758

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants