-
-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impl glfw backend multi context support by adding event queue #7186
Conversation
Hello, Thanks for your PR. This is a backend-side implementation for what's suggested in e.g. #7155 #5671 Here how I would like to rework it:
|
I am interested in using this PR's work. My goal is slightly more ambitious as I want to make ImGui thread safe.
It is not possible to make any code thread safe in a multi-threaded system without at least some form of atomic and/or mutex. The most portable way to do this is to use
see below for why I think it is unnecessary.
I am doing this is my changes on top of #5856 so yes, I believe that is the way to go.
As can be found in the discussion of #5856 after having thought of that, I've come up with a much simpler approach. |
When a previous event handler existed, it is probably better to call it before queueing the event for ImGui processing. |
+1 |
Hmm, I wish you didn’t delete this, i use open issues/pr as references of things that ought to be solved eventually, and this was probably a good base reference. |
Impl multi context support by adding event queue,
test code in windows