Vulkan backend: remove RenderPass parameter, move to ImGui_ImplVulkan_InitInfo #7308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawnhatori
changed the title
ocornut
pushed a commit
that referenced
this pull request
Feb 14, 2024
…lVulkan_Init() function to ImGui_ImplVulkan_InitInfo structure. (#7308)
|
Merged as f80e65a, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaking change moves RenderPass into
ImGui_ImplVulkan_InitInfo, removing the need for any other parameter to initialize the Vulkan backend. This makes for a slightly cleaner interface that behaves more consistently with the Vulkan API itself. It also removes any confusion for users of dynamic rendering, where a VkRenderPass would not be present.With this change, RenderPass is clearly labeled as being ignored if dynamic rendering is enabled, and duplicate struct members can be removed from
ImGui_ImplVulkan_Data.This change has been tested and works as expected.