Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling kdump on ocp worker and master nodes #275

Conversation

Poorna-Gottimukkula1
Copy link
Contributor

@Poorna-Gottimukkula1 Poorna-Gottimukkula1 commented Oct 5, 2023

This PR is to enable the kdump on worker and master nodes

@ppc64le-cloud-bot
Copy link
Contributor

Welcome @Poorna-Gottimukkula1! It looks like this is your first PR to ocp-power-automation/ocp4-upi-powervm 🎉

@ppc64le-cloud-bot
Copy link
Contributor

Hi @Poorna-Gottimukkula1. Thanks for your PR.

I'm waiting for a ocp-power-automation member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yussufsh
Copy link
Contributor

yussufsh commented Oct 5, 2023

/ok-to-test
@Poorna-Gottimukkula1 you are missing newline at the EOF in some places. POSIX defination of a line.

@Poorna-Gottimukkula1 Poorna-Gottimukkula1 changed the title Enabling kdump on ocp worker nodes Enabling kdump on ocp worker and master nodes Oct 6, 2023
Signed-off-by: Poorna Gottimukkula <Poorna.Gottimukkula1@ibm.com>
Copy link
Contributor

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Poorna-Gottimukkula1, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot merged commit 437123c into ocp-power-automation:main Oct 7, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants