Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow multiple clusters (dhcpd) on same shared network #122

Merged
merged 1 commit into from
Oct 13, 2020
Merged

Allow multiple clusters (dhcpd) on same shared network #122

merged 1 commit into from
Oct 13, 2020

Conversation

yussufsh
Copy link
Contributor

Playbook tag Includes:

  1. DHCP server config changes on shared network.
  2. Fix for SSH failures on RHCOS nodes.

Signed-off-by: Yussuf Shaikh yussuf.shaikh@ibm.com

@yussufsh
Allow multiple clusters (dhcpd) on same shared network
f8b0d11 
Signed-off-by: Yussuf Shaikh <yussuf.shaikh@ibm.com>
@ltccci ltccci added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 13, 2020
@yussufsh
Copy link
Contributor Author

/cc @Prajyot-Parab @bpradipt

Prajyot-Parab
Prajyot-Parab approved these changes Oct 13, 2020
View reviewed changes
Copy link
Collaborator

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ltccci ltccci added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2020
bpradipt
bpradipt approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ltccci
Copy link
Contributor

ltccci commented Oct 13, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bpradipt, Prajyot-Parab, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Prajyot-Parab,bpradipt,yussufsh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ltccci ltccci merged commit 0be689d into ocp-power-automation:master Oct 13, 2020
@yussufsh yussufsh deleted the dhcp branch October 13, 2020 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpradipt bpradipt bpradipt approved these changes

@Prajyot-Parab Prajyot-Parab Prajyot-Parab approved these changes

Assignees

@bpradipt bpradipt

@Prajyot-Parab Prajyot-Parab

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yussufsh @ltccci @bpradipt @Prajyot-Parab