Allow adding and deleting worker nodes #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kuldip Nanda <kuldip.nanda@ibm.com> Signed-off-by: Yussuf Shaikh <yussuf.shaikh@ibm.com>
Signed-off-by: Yussuf Shaikh <yussuf.shaikh@ibm.com>
yussufsh
added
do-not-merge/work-in-progress
ltccci
added
approved
bpradipt
reviewed
Jan 16, 2021
| oc adm cordon worker-${count.index} | ||
| oc adm drain worker-${count.index} --force --delete-local-data --ignore-daemonsets | ||
| oc delete node worker-${count.index} | ||
| EOF |
There was a problem hiding this comment.
Is my understanding correct that we can't delete a node by name specifically ?
There was a problem hiding this comment.
oc delete TYPE works with (NAME | -l label | --all) if that is what you are asking.
There was a problem hiding this comment.
My question was more on flexibility of deleting specific node. But I understand it now. Thanks
bpradipt
reviewed
Jan 16, 2021
| @@ -133,6 +133,11 @@ locals { | |||
| } | |||
|
|
|||
| resource "null_resource" "config" { | |||
|
|
|||
| triggers = { | |||
| worker_count = length(var.worker_ips) | |||
There was a problem hiding this comment.
Can you please explain this trigger ?
There was a problem hiding this comment.
Whenever there is a change in the trigger attributes the resource would be re-created after apply. Here whenever the count changes it will run the helpernode again. This is needed for changing the configuration for named, dhcp, etc.
There was a problem hiding this comment.
@yussufsh we are going to need this on kvm also. Is that on your list?
There was a problem hiding this comment.
I do not have a KVM box to implement this at this time. I am working on getting my test setup.
Only issue I am worried about is the use of module dependency we have used in kvm repo. Once I have a test setup I will be able to contribute this change there.
TEST ON OCP4.5.4EnvironmentTest
Initial Run
2nd Run - Increase Worker Count
3rd Run - Decrease Worker Count
4th Run - Increase Worker Count
5th Run - Increase Worker Count
|
Test for 4.6.0 - All Tests done on a new cluster (< 24 hrs.)EnvironmentTestInitial Run2nd Run - Increase Worker Count3rd Run - Decrease Worker Count |
|
/cc @Prajyot-Parab |
TEST ON OCP4.5.23EnvironmentTest
Initial Run
Increase Worker Count
NAME STATUS ROLES AGE VERSION
master-0 Ready master 17h v1.18.3+fa69cae
master-1 Ready master 17h v1.18.3+fa69cae
master-2 Ready master 17h v1.18.3+fa69cae
worker-0 Ready worker 17h v1.18.3+fa69cae
worker-1 Ready worker 16h v1.18.3+fa69cae
worker-2 Ready worker 23m v1.18.3+fa69cae
worker-3 Ready worker 17m v1.18.3+fa69caeDecrease Worker Count
Increase Worker Count
Decrease Worker Count
|
bpradipt
approved these changes
Jan 18, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bpradipt, Prajyot-Parab, yussufsh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Kuldip Nanda kuldip.nanda@ibm.com
Signed-off-by: Yussuf Shaikh yussuf.shaikh@ibm.com