Stackoverflow error thrown by showcase's access control

[balteo]

Hi all,
It seems a stackoverflow error is thrown by the access control app.
I have attached the full JBoss 7 logs here: http://ocpsoft.org/support/topic/stackoverflow-error-thrown-by-showcases-access-control#post-3242
Regards,
Julien Martin.

[chkal]

Confirmed... Ups... I'll have a look...

[chkal]

I just had a deeper look at this problem. This rule creates an endless forward:

.addRule(Join.path("/{global}").to("/{global}.xhtml")
.when(JodaTime.matches(timeGranted))
.withInboundCorrection())

It seems like /test is forwarded to /test.xhtml and is then forwarded to /test.xhtml.xhtml and then to /test.xhtml.xhtml.xhtml and so on.

I fixed this by changing the rule this way:

.addRule(Join.path("/{global}").to("/{global}.xhtml")
.when(JodaTime.matches(timeGranted).and(DispatchType.isRequest()))
.withInboundCorrection())

Please note the DispatchType.isRequest() in the when() part. This restricts the rule to don't match forwards anymore.

@lincolnthree: What do you think? Shouldn't Join already add a condition DispatchType.isRequest(). Or is there a usecase for Join to match on forwards? I'm not sure on this one.

[lincolnthree]

Hmmm... yeah, that's a bad one. Strange I've never noticed this before. I think Join should probably use the addition you recomend. It's meant to be a convenience, not something that is confusing. If people need to intercept forwards, they should not use Join IMO.

[chkal]

OK, I'll create an issue for this.

[chkal]

I opened #51 for this. So I think this one can be closed.

[lincolnthree]

Sounds good.