hocr-check: Replace assert calls with basic TAP ok test #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* test function 'test_ok(boolean, message)' * Failing tests will write 'not ok' and the message * Passing tests will write 'ok' and the message
| for line in lines: | ||
| assert line.xpath("//*[@class='ocr_page']") | ||
| for line_idx, line in enumerate(lines): | ||
| test_ok(line.xpath("//*[@class='ocr_page']"), "ocr_line %2d in a ocr_page"%(line_idx)) |
There was a problem hiding this comment.
Isn't this checking for a ocr_page inside the line element?
There was a problem hiding this comment.
They are supposed to check for the opposite but don't and should be fixed. All those tests in for loops.
There was a problem hiding this comment.
Okay, and the current tests are just checking that it is possible to execute hocr-check with the correct parameters. I guess that the current output of the command is showing not okay lines. Correct?
There was a problem hiding this comment.
//*[@class='ocr..'] without context starts at root, so will output ok. Your expected behavior is for .//*[@class='ocr..']
|
Thanks for merging, you can see the output at http://digi.bib.uni-mannheim.de/ocr-fileformat/#validate |
kba
added a commit
to kba/hocr-tools
that referenced
this pull request
Sep 15, 2016
* test function 'test_ok(boolean, message)' * Failing tests will write 'not ok' and the message * Passing tests will write 'ok' and the message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a really simplistic approach on how hocr-check can be more useful.