Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hocr-lines: Use lxml for text content, strict test, #86 #87

Merged
merged 2 commits into from
Oct 23, 2016
Merged

hocr-lines: Use lxml for text content, strict test, #86 #87

merged 2 commits into from
Oct 23, 2016

Conversation

kba
Copy link
Contributor

@kba kba commented Oct 17, 2016

@kba
Copy link
Contributor Author

kba commented Oct 17, 2016

breaks 2.7 on travis https://travis-ci.org/kba/hocr-tools/jobs/168311160

@kba kba force-pushed the lines-text-py3 branch 2 times, most recently from 91fb7a0 to 69d526a Compare October 17, 2016 14:18
@kba
Copy link
Contributor Author

kba commented Oct 17, 2016

Fixed, the encoding error is a red herring, it's the console I/O that must be in UTF-8, otherwise Python 2 will assume latin. Fixed in travis.yml, build passes.

zuphilip
zuphilip approved these changes Oct 17, 2016
View reviewed changes
Copy link
Collaborator

@zuphilip zuphilip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine for me, also I am no expert with all these encoding things.

@zuphilip zuphilip merged commit d1214bc into ocropus:master Oct 23, 2016
@zuphilip zuphilip mentioned this pull request Oct 23, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zuphilip zuphilip zuphilip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kba @zuphilip