Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure to build with dune cache enabled #772

Closed
kit-ty-kate opened this issue Nov 30, 2023 · 1 comment · Fixed by #773
Closed

Failure to build with dune cache enabled #772

kit-ty-kate opened this issue Nov 30, 2023 · 1 comment · Fixed by #773

Comments

@kit-ty-kate
Copy link
Member

Everything is written in ocaml/dune#9283 but in a nutshell this line (https://github.com/ocsigen/eliom/blob/10.1.2/src/lib/server/dune#L30-L33) and the rule above that one, probably need an extra (deps (universe)) to be correct or something like that.

@emillon would that work?

@emillon
Copy link

emillon commented Nov 30, 2023

That's not the ideal fix, but yes, probably it would fix the issue.

vouillon added a commit that referenced this issue Dec 4, 2023
- no longer use ppx_eliom_types
- fix Js_of_ocaml include hack (fixes #772)
vouillon added a commit that referenced this issue Dec 4, 2023
- no longer use ppx_eliom_types
- fix Js_of_ocaml include hack (fixes #772)
vouillon added a commit that referenced this issue Dec 4, 2023
- no longer use ppx_eliom_types
- fix Js_of_ocaml include hack (fixes #772)
vouillon added a commit that referenced this issue Dec 4, 2023
- no longer use ppx_eliom_types
- fix Js_of_ocaml include hack (fixes #772)
vouillon added a commit that referenced this issue Dec 4, 2023
- no longer use ppx_eliom_types
- fix Js_of_ocaml include hack (fixes #772)
@balat balat closed this as completed in #773 Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants