Add support for transition events. #1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. It would be nice to perform the corresponding changes in Can you also add a changelog entry ? |
|
I made an attempt, let me know if it's reasonable or not. One behaviour difference here that seems maybe hard to avoid - previously we tried to identify a kind of transitionend event that is supported by the browser by trying out a bunch of different options and if we failed to find any, then we'd end up returning from [transitionend] immediately, whereas now we hang forever. That both seems to only potentially be a problem in fairly ancient browsers, but also seems more correct anyway? |
hhugo
reviewed
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.