Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ppx_js: behave better with merlin #933

Merged
merged 1 commit into from
Jan 3, 2020
Merged

ppx_js: behave better with merlin #933

merged 1 commit into from
Jan 3, 2020

Conversation

trefis
Copy link
Contributor

@trefis trefis commented Nov 28, 2019

No description provided.

@TyOverby
Copy link
Collaborator

TyOverby commented Nov 29, 2019

@trefis please run make fmt

The failure in CI is due to ocamlformat

@hhugo
Copy link
Member

hhugo commented Nov 30, 2019

I'll try to run some tests later this weekend.

@hhugo
Copy link
Member

hhugo commented Dec 3, 2019

merlin.hide seems to be hiding/ignoring too much information.
In particular, asking the type of the right hand side of ##. or ## doesn't seems to work.
By rhs, I mean xxx in expressions bellow
o##xxx
o##xxx a b c
o##.xxx
o##.xxx := e

@trefis
Copy link
Contributor Author

trefis commented Dec 18, 2019

I have just pushed a new version which should behave as well as the current ppx (I have even noticed some improved answers).

@trefis
Copy link
Contributor Author

trefis commented Dec 31, 2019

@hhugo: CI is green.

ppx/ppx_js/tests/ppx.mlt Outdated Show resolved Hide resolved
ppx/ppx_js/tests/ppx.mlt Outdated Show resolved Hide resolved
Signed-off-by: Thomas Refis <thomas.refis@gmail.com>
@hhugo hhugo merged commit 2fb533d into ocsigen:master Jan 3, 2020
@hhugo
Copy link
Member

hhugo commented Jan 3, 2020

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants