-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mac arm support by upgrading playwright's version to 1.25.1 #36
base: master
Are you sure you want to change the base?
Conversation
Make sure to delete all cache locations before testing: rm -rf /tmp/build-playwright-rust
rm -rf $HOME/Library/Caches/ms-playwright
rm -rf target Otherwise, the build script will likely use the last installed version, which in my case was 1.11.0-1620331022000. |
I'm working on 1.25 in the dev branch, so please wait. |
if this could get merged that would be swell, am happy to contribute testing anything if you need |
Any updates on this PR? I would love to see it supported. |
Judging from the fact that the PR has been posted a few months ago, @octaltree is probs bussy with life. No one really knows when 1.25.1 or later will be released if ever. In the mean time, feel free to use my branch. |
Had an issue where it would tell me that mac12 is not supported (old Playwright), tried using this branch with 1.25.1 and even a newer version 1.30 but keep getting |
Make sure to read the above comment #36 (comment) It's likely that you're actually still using an older version under the hood. |
Thanks for the reply, I did run the remove commands still had the same result. Although it seems for my use case playwright is not necessary after more research. |
Just as a note: same error on my side, even after running the commands, so something seems to be broken. |
Tested locally by running
cargo run -- install firefox
andcargo run -- ff google.com
.Installing the driver would fail on 1.11.0-1620331022000 because the m1 platform wasn't supported back then.
Let me know if there's something else you'd like done to get this merged to master.
Solves #27.