Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mac arm support by upgrading playwright's version to 1.25.1 #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zexa
Copy link

@zexa zexa commented Sep 5, 2022

Tested locally by running cargo run -- install firefox and cargo run -- ff google.com.

Installing the driver would fail on 1.11.0-1620331022000 because the m1 platform wasn't supported back then.

Let me know if there's something else you'd like done to get this merged to master.

Solves #27.

@zexa
Copy link
Author

zexa commented Sep 5, 2022

Make sure to delete all cache locations before testing:

rm -rf /tmp/build-playwright-rust
rm -rf $HOME/Library/Caches/ms-playwright
rm -rf target

Otherwise, the build script will likely use the last installed version, which in my case was 1.11.0-1620331022000.

@octaltree
Copy link
Owner

I'm working on 1.25 in the dev branch, so please wait.

@matthiasdebernardini
Copy link

if this could get merged that would be swell, am happy to contribute testing anything if you need

@21st-centuryman
Copy link

Any updates on this PR? I would love to see it supported.

@zexa
Copy link
Author

zexa commented Jan 19, 2023

Any updates on this PR? I would love to see it supported.

Judging from the fact that the PR has been posted a few months ago, @octaltree is probs bussy with life. No one really knows when 1.25.1 or later will be released if ever.

In the mean time, feel free to use my branch.

@ghost
Copy link

ghost commented Feb 8, 2023

Had an issue where it would tell me that mac12 is not supported (old Playwright), tried using this branch with 1.25.1 and even a newer version 1.30 but keep getting InitializationError when calling Playwright::initialize() now. Tried to poke around the code without any success unfortunately, am I the only one having problems calling initialization?

@zexa
Copy link
Author

zexa commented Feb 9, 2023

Had an issue where it would tell me that mac12 is not supported (old Playwright), tried using this branch with 1.25.1 and even a newer version 1.30 but keep getting InitializationError when calling Playwright::initialize() now. Tried to poke around the code without any success unfortunately, am I the only one having problems calling initialization?

Make sure to read the above comment #36 (comment)

It's likely that you're actually still using an older version under the hood.

@ghost
Copy link

ghost commented Feb 9, 2023

Make sure to read the above comment #36 (comment)

It's likely that you're actually still using an older version under the hood.

Thanks for the reply, I did run the remove commands still had the same result. Although it seems for my use case playwright is not necessary after more research.

@daniel-abramov
Copy link

Just as a note: same error on my side, even after running the commands, so something seems to be broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants