Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open raw sockets when adding hosts, not when doing the pinging #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tfheen
Copy link

@tfheen tfheen commented Mar 20, 2018

This allows this to run as non-root again, without this, oping will
have dropped privileges before trying to ping, which then fails to
open the necessary raw sockets.

Fixes: #34

This allows this to run as non-root again, without this, oping will
have dropped privileges before trying to ping, which then fails to
open the necessary raw sockets.

Fixes: octo#34
@barak
Copy link

barak commented Mar 21, 2018

I've uploaded a version to Debian that includes this fix.

@ghost
Copy link

ghost commented Jan 28, 2019

Could this be related to #43 - I'm using Ubuntu version which most likely includes the same fix.

@cron2
Copy link
Contributor

cron2 commented Feb 2, 2021

Hi,

this patch (or something along that lines) is necessary for oping/noping to work correctly on FreeBSD for non-root users (running suid root). "master as is" will drop privs too early, resulting in a cascade of

ping_send failed: Operation not permitted
ping_send failed: Operation not permitted
ping_send failed: Operation not permitted
ping_send failed: Operation not permitted
ping_send failed: Operation not permitted

even when installed mode 4711 (suid root). @octo can you please merge this, or something similar?

I am willing test variants on FreeBSD.

We use noping a lot, but we want the multiping patch, so we need "master + privilege dropping fix"...

thanks

woodsts pushed a commit to woodsts/buildroot that referenced this pull request Dec 30, 2021
Add patch from upstream merge quest [1] to fix suid root feature.

[1] octo/liboping#35

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fails when run as suid root
3 participants