Fix for #5300 - Wrong type hinting for config variable #5330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bennothommo we need to lock the test suite to running composer 1.0 until wikimedia/composer-merge-plugin#189 is merged. Ideally we should probably help test that PR and get it merged in ASAP as composer 2.0 is now out. |
bennothommo
added a commit
that referenced
this pull request
Oct 25, 2020
Until such a time that `wikimedia/composer-merge-plugin` supports Composer 2. Refs: #5330 (comment)
bennothommo
added a commit
to octobercms/library
that referenced
this pull request
Oct 25, 2020
Until such a time that `wikimedia/composer-merge-plugin` supports Composer 2. Refs: octobercms/october#5330 (comment)
|
@LukeTowers I've updated the test suite for October and Rain library - I'll need to do the same for the RainLab plugins that have tests at some point later today. |
|
Please resubmit if desired, not sure why the tests aren't liking this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were 2 occurrences of incorrect type hinting for the variable
$config. It was declared as an array while it was being used as an object. These are the 2 occurrences:october/modules/backend/classes/ControllerBehavior.php
Line 26 in af6db51
october/modules/system/traits/ConfigMaker.php
Line 30 in af6db51
This PR is an attempt to fix issue #5300