CloudflareProvider: Map TTL=1 to 300 #210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not change to ? It will keep default behavior of Cloudflare API. |
4 tasks
yzguy
changed the title
|
Closing this as effectively stale and the provider has been moved out into its own repo https://github.com/octodns/octodns-cloudflare/. Feel free to rework/reopen this PR there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will map the Cloudflare ttl of 1 to 300s which based on this support thread is the behavior users would be getting there. The result of this will be that automatic ttl things dumped from CF would have 300s ttls in the resulting output which would once synced to CF and other places result in matching/preserving behaviors. It won't change anything that's already 1 in CF unless the record otherwise is being modified.
I think this is our best option for handling the automatic TTLs with the mindset of trying to get multiple providers to behavior the same way from a single config (octoDNS's mindset.)
/cc Fixes https://github.com/github/octodns/issues/202
/cc Replaces #204
/cc @vanbroup @ad-m for thoughts