Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "as_finite_datetime_periods" fn #134

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Conversation

benthorner
Copy link
Contributor

Needed for octoenergy/kraken-core#116552

This can be used as part of a broader conversion of (finite)
date / time periods to finite date periods - the date part of
the conversion is too simple / specific to add here as well.

This will be useful in the following commit, and also externally
where such ranges are used. In order to refer to HalfFiniteRange
under the existing comment we need to move it down.
Copy link

@leamingrad leamingrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@benthorner benthorner merged commit b65fbe9 into main Jan 16, 2024
1 check passed
@benthorner benthorner deleted the finite-dt-range-cast-2 branch January 16, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants