Fix bug in FiniteDateRange.days property #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this property would return a value exclusive of the end date. However the FiniteDateRange defines it's boundaries as double inclusive, therefore this value was off by one. This change includes the range end date in the count of days.
josh-lynch
force-pushed
the
ranges/bugfix-days
branch
from
d8b95dc
to
d760adc
Compare
|
This PR addresses a long standing bug in the ranges module. It seems likely that a lot of code will have been developed to depend on this bug, as such we will need to be careful about the release of this change. For kraken-core (and other in house repos I assume) we can rely on CI picking up any potential breakages this change will cause. However as this repo is now open source I'm not sure how we manage the risk for other users, do we need to consider a major version change? |
|
Related PR: #99 |
meshy
reviewed
Oct 12, 2023
samueljsb
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this property would return a value exclusive of the end
date. However the FiniteDateRange defines it's boundaries as double
inclusive, therefore this value was off by one.
This change includes the range end date in the count of days.