Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(README): caching per instance #39

Merged
merged 1 commit into from
Jun 16, 2019
Merged

docs(README): caching per instance #39

merged 1 commit into from
Jun 16, 2019

Conversation

gr2m
Copy link
Contributor

@gr2m gr2m commented Jun 15, 2019 •
edited by markdownify bot
Loading

ping @chrishiestand does that change make it clear?

View rendered README.md

@chrishiestand
Copy link

Thanks @gr2m! It's better! I suggest the following to make it even more obvious:

By default, each App instance creates a dedicated lru-cache, caching up to 15000 tokens simultaneously.

@chrishiestand
Copy link

But I defer to your judgement.

gr2m
gr2m commented Jun 16, 2019
View reviewed changes
Copy link
Contributor Author

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect 👌

@gr2m gr2m merged commit ebe3264 into master Jun 16, 2019
@wolfy1339 wolfy1339 mentioned this pull request Jun 21, 2019
Closed
@octokitbot
Copy link
Collaborator

🎉 This PR is included in version 3.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gr2m @chrishiestand @octokitbot