This repository has been archived by the owner on Jun 20, 2022. It is now read-only.
Implemented Collaborators API using the new pattern #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,23 @@ | |||
| package octokit | |||
There was a problem hiding this comment.
As I mentioned in Slack, I'd probably name this file repo_collaborators_test.go.
|
Looking good @dhruvsinghal. Gonna tackle the other |
|
Implemented the remaining GET call. @pengwynn Please take a look. |
| @@ -35,6 +35,12 @@ func (r *Request) Get(output interface{}) (*Response, error) { | |||
| return r.createResponse(r.Request.Get(), output) | |||
| } | |||
|
|
|||
| // Get sends a GET request through the given client and returns the response | |||
| // and any associated errors. It does not fill in a response body. | |||
| func (r *Request) GetBodyless() (*Response, error) { | |||
There was a problem hiding this comment.
Not seeing why we need a new method here. Can we not make Get handle those types of responses?
|
Had one question on this one @dhruvsinghal. Ping me and add the |
|
@pengwynn Please take a look. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pengwynn please take a look