-
Notifications
You must be signed in to change notification settings - Fork 79
Implemented Collaborators API using the new pattern #99
Conversation
@@ -0,0 +1,23 @@ | |||
package octokit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I mentioned in Slack, I'd probably name this file repo_collaborators_test.go
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Looking good @dhruvsinghal. Gonna tackle the other |
Implemented the remaining GET call. @pengwynn Please take a look. |
@@ -35,6 +35,12 @@ func (r *Request) Get(output interface{}) (*Response, error) { | |||
return r.createResponse(r.Request.Get(), output) | |||
} | |||
|
|||
// Get sends a GET request through the given client and returns the response | |||
// and any associated errors. It does not fill in a response body. | |||
func (r *Request) GetBodyless() (*Response, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not seeing why we need a new method here. Can we not make Get
handle those types of responses?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Had one question on this one @dhruvsinghal. Ping me and add the |
@pengwynn Please take a look. |
@pengwynn please take a look