Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Code of Conduct preview endpoint support ✨ #555

Merged
merged 1 commit into from
Aug 18, 2017

Conversation

hiimbex
Copy link
Contributor

@hiimbex hiimbex commented Jul 14, 2017

This PR adds support for the Code of Conduct GitHub API (in preview period) documented here: https://developer.github.com/v3/codes_of_conduct/

Tests and api docs generated. README updated for preview headers. npm requests that I commit the package-lock.json file, but please let me know if that is not the case.

cc/ @bkeepers @jbjonesjr

Copy link

@bkeepers bkeepers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zeke
Copy link

zeke commented Aug 15, 2017

Awesome. Didn't know these new endpoints were a thing. 👍

The test suite is still not working. How can we ship these changes with confidence? Are you folks smoke-testing this stuff?

@hiimbex
Copy link
Contributor Author

hiimbex commented Aug 15, 2017

The test suite is still not working. How can we ship these changes with confidence? Are you folks smoke-testing this stuff?

I verified all the end points work by replacing the values in the testing suite with real ones and verifying those work. Since then I've been replacing the package in my node_modules with the code from my branch and had success hitting these endpoints.

I agree that this kind of testing doesn't give me great confidence in my changes. I'd be happy to update once we get some new testing infrastructure set up! :)

@kaizensoze kaizensoze merged commit e7bb6fc into octokit:master Aug 18, 2017
@kaizensoze
Copy link

Thanks!

@hiimbex hiimbex deleted the add-code-of-conduct branch August 18, 2017 15:16
@zeke
Copy link

zeke commented Aug 18, 2017

Hey @hiimbex!

@gr2m and I have started working on a fork in the octokit org. I tried to pull in the changes from this PR but things have already diverged enough to generate some conflicts.

Can you tell me which files you modified manually to make this change?

@hiimbex
Copy link
Contributor Author

hiimbex commented Aug 18, 2017

Yes! would it be easier for me to just open a PR there?

If not I edited the README to reflect the preview header and routes.json. Everything else was generated, but I think the index files are necessary while the test is ❓

@zeke
Copy link

zeke commented Aug 18, 2017

would it be easier for me to just open a PR there?

Yes please 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants