Add gist get support #225

SimonCropp · 2013-11-14T06:59:27Z

No description provided.

shiftkey · 2013-11-14T18:44:27Z

Octokit.Tests.Integration/GistsClientTests.cs

+            var retrieved = await this._gistsClient.Get(6305249);
+            Assert.NotNull(retrieved);
+        }
+


W H I T E S P A C E

And let's assert a little more than it's not null. 😄

shiftkey · 2013-11-14T18:58:05Z

Looks like lots of the groundwork is in there for the rest of the Gist API - is that part of the plan or am I getting ahead of myself?

A few little whitespace issues, and that failing test, but it looks promising so far!

SimonCropp · 2013-11-14T21:37:20Z

@shiftkey well I only needed Get. happy to continue with the rest in the background. it is mostly manual work.

the next thing I need is http://developer.github.com/v3/git/ is anyone working on this?

shiftkey · 2013-11-14T23:25:52Z

@SimonCropp

happy to continue with the rest in the background. it is mostly manual work.

I'm cool with that. Stub out out the other methods with a NotImplementedException("You can submit a pull request for this to https://github.com/octokit/octokit.net/") exception so we don't forget them. cc @haacked

the next thing I need is http://developer.github.com/v3/git/ is anyone working on this?

Blobs and Trees are underway #188 and #194 - which I'll review again and probably merge in today for a 0.1.5 release early next week.

SimonCropp · 2013-11-15T06:29:45Z

@shiftkey @haacked turns out secrets gists have a non-numeric id. so dont merge this yet

SimonCropp · 2013-11-15T07:14:04Z

@shiftkey so can this be merged?

shiftkey · 2013-11-15T14:33:34Z

In it's current form, the magic "Merge pull request" button is disabled.

I think the .csproj changes from master need to be merged in.

I'll also just run through the latest changes just in case I missed something.

shiftkey · 2013-11-15T14:34:23Z

Octokit/Clients/IGistsClient.cs

+        [SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get",
+            Justification = "Method makes a network request")]
+        Task<Gist> Get(string id);
+


a little less whitespace

shiftkey · 2013-11-15T14:43:18Z

Oh, and run .\build.cmd FixProjects to sync the new files across the Mono* projects ✨

SimonCropp · 2013-11-20T21:47:05Z

@shiftkey

.\build.cmd FixProjects
The system cannot find the path specified.
(Q)uit, (Enter) runs the build again

shiftkey · 2013-11-20T22:01:23Z

.\build.cmd FixProjects
The system cannot find the path specified.
(Q)uit, (Enter) runs the build again

Are you running it from Powershell or cmd or something crazy I haven't tested on?

SimonCropp · 2013-11-20T22:05:21Z

was running in CMD. but fails in powerhell as well

but i did notice another error flick up for a second. had to print screen it

shiftkey · 2013-11-20T22:09:06Z

@SimonCropp do a git clean -xdf to clear up that file.

cc @forki to remind me to review that script and try-catch the way out

SimonCropp · 2013-11-20T22:18:03Z

same error

seems u have a bunch of stuff that assume existence of tools\FAKE.Core\ which does not exist on my machine

shiftkey · 2013-11-20T22:26:49Z

@SimonCropp I'm able to see this issue on master - digging a bit deeper into it

SimonCropp · 2013-11-20T22:27:32Z

sooo. can we merge this one ;)

haacked · 2013-11-20T22:42:06Z

Build.cmd is prompting. I thought we removed that prompt. It shouldn't have any sort of user interaction like that.

SimonCropp · 2013-11-20T22:43:11Z

@haacked @shiftkey happy to screen share if u guys want to troubleshoot on my machine

forki · 2013-11-20T23:26:01Z

Actually I broke fake for one or two hours. Sorry about that. Maybe you got a broken version. Can you delete tools/fake and retry?

shiftkey · 2013-11-20T23:40:55Z

@haacked

Build.cmd is prompting.

It still is. Let me fix it.

@SimonCropp your %LOCALAPPDATA%\NuGet\Cache\ is probably like this

@forki I'm still seeing the 0KB file be downloaded to the local cache - are you able to publish a new release?

SimonCropp · 2013-11-20T23:45:07Z

@shiftkey yep i have a 0byte file.

forki · 2013-11-21T00:57:51Z

Still broken?? Wtf

SimonCropp · 2013-11-21T01:01:37Z

@forki did u unlist 757? 756 looks good but i cant see 757. if u want to get nuget to fix it u prob need to push a fixed version with a higher number than the broken one

shiftkey · 2013-11-21T01:02:03Z

Running FAKE.Core.2.1.758-alpha is now kicking off the build, but there's a different issue here with the generated SolutionInfo.cs file.

    internal static class AssemblyVersionInformation {
        internal const string Version = "0.1.5";
    }
}

That closing brace is causing some compile issues.

forki · 2013-11-21T01:28:41Z

I'm really sorry. I hope it works now. Something broke during nuget push.

It teaches me a lesson to finally release FAKE 2.0 in order to detach the important projects from the prerelease channel.
I think everyone is already using 2.x so it should be ok

SimonCropp · 2013-11-21T09:44:16Z

@shiftkey so the projects are now synced. anything else?

shiftkey · 2013-11-21T16:58:25Z

@SimonCropp I'm still seeing the broken SolutionInfo.cs file in FAKE version 2.1.766.

@forki is there something I'm missing?

forki · 2013-11-21T19:04:41Z

This is so embarrassing.

I reverted FAKE to a good version. Octokit now builds on my machine.

I promise to release FAKE 2 today and then we can move Octokit and other important projects on the stable release channel.

I'm really sorry that I broke it. But I will give my best to improve it.

shiftkey · 2013-11-21T19:08:06Z

@forki that's fine - happens to the best of us. Let me know when it's 🆒 and we can try again

forki · 2013-11-21T19:14:07Z

Thanks.

Please try again the "good" (old) version is already on nuget.

shiftkey · 2013-11-21T19:21:53Z

@forki got it

@SimonCropp looks good, would be nice to test that some of the properties on the gist response - like Owner for example - is not null

Let's see if @haacked has any issues

SimonCropp · 2013-11-21T21:37:57Z

@shiftkey well my intent was actually to do some serialization tests on a future PR. but I initially wanted to "make it work" then iterate on that

haacked · 2013-11-21T21:56:09Z

Fine with me

Add gist get support

SimonCropp · 2013-11-21T22:11:58Z

Merged and Closed = Win :)

SimonCropp added 2 commits November 14, 2013 12:44

add gist get

0b0661a

fix user mapping and add doco

cc77928

shiftkey reviewed Nov 14, 2013
View reviewed changes

fix gist test and remove some whitespace

f0ea90b

gist id can be a string

ae34ccd

shiftkey reviewed Nov 15, 2013
View reviewed changes

fixes for @shiftkey

383ec59

SimonCropp added 2 commits November 21, 2013 08:52

Merge remote-tracking branch 'upstream/master'

011bfa7

fix merge issue

c7a1766

sync projects

0440888

shiftkey added a commit that referenced this pull request Nov 21, 2013

Merge pull request #225 from SimonCropp/master

074dce7

Add gist get support

shiftkey merged commit 074dce7 into octokit:master Nov 21, 2013

shiftkey mentioned this pull request Nov 29, 2013

How to handle files in a gist response #215

Closed

Add gist get support #225

Add gist get support #225

Conversation

SimonCropp commented Nov 14, 2013

shiftkey Nov 14, 2013

Choose a reason for hiding this comment

haacked Nov 14, 2013

Choose a reason for hiding this comment

shiftkey commented Nov 14, 2013

SimonCropp commented Nov 14, 2013

shiftkey commented Nov 14, 2013

SimonCropp commented Nov 15, 2013

SimonCropp commented Nov 15, 2013

shiftkey commented Nov 15, 2013

shiftkey Nov 15, 2013

Choose a reason for hiding this comment

shiftkey commented Nov 15, 2013

SimonCropp commented Nov 20, 2013

shiftkey commented Nov 20, 2013

SimonCropp commented Nov 20, 2013

shiftkey commented Nov 20, 2013

SimonCropp commented Nov 20, 2013

shiftkey commented Nov 20, 2013

SimonCropp commented Nov 20, 2013

haacked commented Nov 20, 2013

SimonCropp commented Nov 20, 2013

forki commented Nov 20, 2013

shiftkey commented Nov 20, 2013

SimonCropp commented Nov 20, 2013

forki commented Nov 21, 2013

SimonCropp commented Nov 21, 2013

shiftkey commented Nov 21, 2013

forki commented Nov 21, 2013

SimonCropp commented Nov 21, 2013

shiftkey commented Nov 21, 2013

forki commented Nov 21, 2013

shiftkey commented Nov 21, 2013

forki commented Nov 21, 2013

shiftkey commented Nov 21, 2013

SimonCropp commented Nov 21, 2013

haacked commented Nov 21, 2013

SimonCropp commented Nov 21, 2013