Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: drop GHES 3.5, add GHES 3.8 & 3.9, endpoint docs update #575

Merged
merged 7 commits into from
Jun 12, 2023
Merged

feat: drop GHES 3.5, add GHES 3.8 & 3.9, endpoint docs update #575

merged 7 commits into from
Jun 12, 2023

Conversation

wolfy1339
Copy link
Member

Behavior

Before the change?

  • Support for GHES 3.8 and 3.9 was missing

After the change?

  • Adds support for GHES 3.8 and 3.9

Other information

Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • Drops GHES 3.5 support

Pull request type

Please add the corresponding label for change this PR introduces:

  • Feature/model/API additions: Type: Feature

@wolfy1339 wolfy1339 added Type: Feature New feature or request Type: Breaking change Used to note any change that requires a major version bump labels Jun 9, 2023
@wolfy1339 wolfy1339 changed the title feat: drop GHES 3.5, endpoint docs update feat: drop GHES 3.5, add GHES 3.8 & 3.9, endpoint docs update Jun 9, 2023
@wolfy1339 wolfy1339 mentioned this pull request Jun 9, 2023
Merged
@kfcampbell
Copy link
Member

@wolfy1339 are you comfortable releasing this? I can add the "BREAKING CHANGE" description and merge if so!

@wolfy1339
Copy link
Member Author

I would merge this and #564 together into the beta branch so we only do one single major release

@kfcampbell
Copy link
Member

kfcampbell commented Jun 12, 2023 •
edited
Loading

Sounds good to me! I'm on it.

@kfcampbell kfcampbell changed the base branch from main to beta June 12, 2023 21:38
@kfcampbell kfcampbell merged commit 9ef5e11 into beta Jun 12, 2023
@kfcampbell kfcampbell deleted the update-ghes-versions branch June 12, 2023 21:38
wolfy1339 added a commit that referenced this pull request Jun 12, 2023
@kfcampbell @wolfy1339
feat: v13 (#577)
5ab8c34 
* feat: drop GHES 3.5, add GHES 3.8 & 3.9, endpoint docs update (#575)
* feat: add support for GHES 3.8 and 3.9
* feat: endpoint description updates

BREAKING CHANGE: remove GHES 3.5 support
BREAKING CHANGE: Drop support for NodeJS v14, v16

---------

Co-authored-by: wolfy1339 <4595477+wolfy1339@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfcampbell kfcampbell kfcampbell approved these changes

Assignees
No one assigned
Labels
Type: Breaking change Used to note any change that requires a major version bump Type: Feature New feature or request
Projects
🧰 Octokit Active
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wolfy1339 @kfcampbell