Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a pull request in fork A from fork B #222

Closed
kaovilai opened this issue Oct 14, 2022 · 5 comments
Closed

Create a pull request in fork A from fork B #222

kaovilai opened this issue Oct 14, 2022 · 5 comments
Labels
Type: Support Any questions, information, or general needs around the SDK or GitHub APIs

Comments

@kaovilai
Copy link

What’s missing?
Looking at https://octokit.github.io/rest.js/v19#pulls-create there doesn't seem to be a way to create pull request from fork to fork.

Why?
It's needed to be done

Alternatives you tried
Could probably do some CLI hacks or other alternative in the interim.

@gr2m
Copy link
Contributor

gr2m commented Oct 14, 2022

does GitHub itself support this feature? I think only if fork B is a fork from A

@gr2m gr2m added Type: Support Any questions, information, or general needs around the SDK or GitHub APIs and removed Type: Feature New feature or request labels Oct 14, 2022
@kaovilai
Copy link
Author

kaovilai commented Oct 14, 2022

Yes. Edit: let me find better example

@kaovilai
Copy link
Author

@gr2m An example of fork to fork demo.
gr2m/fetch-mock#1

Both are forks of https://github.com/wheresrhys/fetch-mock

@gr2m
Copy link
Contributor

gr2m commented Oct 14, 2022

try to set head to username:branch.

Basically we can't add features that the API doesn't support. If the REST API can do it, then @octokit/rest can do it. See the docs for the REST API at https://docs.github.com/en/rest/pulls/pulls#create-a-pull-request

@kaovilai
Copy link
Author

Resolved. It is possible with current library.
Had to make some changes in the actions I consumed.
tgymnich/fork-sync@master...b89779a#diff-7934bf411fea192ad8cd69e0a12911648a2842cb0f2409a8fb67b41b7069d757R68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Support Any questions, information, or general needs around the SDK or GitHub APIs
Projects
None yet
Development

No branches or pull requests

2 participants