fix: remove all whitespace when stringifying a webhook event payload object to a JSON string for verifycation #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfy1339
added
the
Type: Bug
|
Something is up with the tests. |
gr2m
force-pushed
the
fix-remove-json-stringify-pretty-print
branch
from
d98a2e6
to
234c7b4
Compare
gr2m
changed the title
toNormalizedJsonString()toNormalizedJsonString()
I didn't fix the hanging tests in case of a signature mismatch, but I fixed the cause of the mismatch itself. I'd say lets get this out asap, we can worry about tests later |
gr2m
changed the title
toNormalizedJsonString()
gr2m
approved these changes
Jun 21, 2021
|
As this is a hotfix, I went ahead and merged it @wolfy1339. Please feel free to add any review comments anyway, I'll create follow up issues if needed |
|
🎉 This PR is included in version 9.8.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced in 1127c91
Fixes #593