Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema updates #576

Merged
merged 22 commits into from
Nov 22, 2021
Merged

Schema updates #576

merged 22 commits into from
Nov 22, 2021

Conversation

wolfy1339
Copy link
Member

@wolfy1339 wolfy1339 commented Oct 11, 2021 •
edited
Loading

  • feat: new keys permission for apps
  • feat: new run_attempt, run_started_at and previous_attempt_url properties for workflow_run
  • feat: new topics property for repository
  • feat: new run_attempt property on workflow_job
  • feat: new allow_update_branch property on Repository
  • feat: new draft property on issue object
  • feat: visibility is a required field on repository
  • fix: repository is not always present for project_card events
  • fix: add internal to allowed values for repository#visibility
  • fix: the property check_suite#after can be null
  • fix: add missing branch_protection_rule event to App
  • fix: correct typo in enum for App key permission

@wolfy1339 wolfy1339 added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Oct 11, 2021
@wolfy1339 wolfy1339 mentioned this pull request Oct 11, 2021
Merged
bdatdo0601
bdatdo0601 approved these changes Oct 22, 2021
View reviewed changes
Copy link

@bdatdo0601 bdatdo0601 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

I have confirmed that this is currently breaking latest webhook (missing topics in repo)

@wolfy1339 wolfy1339 force-pushed the schema-updates branch 2 times, most recently from 998df9b to 2195522 Compare November 22, 2021 01:32
@wolfy1339
feat: new keys permission for apps
579527c
@wolfy1339
feat: new run_attempt, run_started_at and previous_attempt_url …
7012cb4 
…properties for `workflow_run`
@wolfy1339
feat: update payloads for the workflow_run event
8db569c
@wolfy1339
feat: new topics property for repository
831d811
@wolfy1339
feat: update example payloads for new topics property
9feb695
@wolfy1339
build: generate types
eb3c18f
@wolfy1339
build: generate index.json
5b58e2c
@wolfy1339
build: generate types
d763781
@wolfy1339
feat: repository is not always present on project_card
06cd305 
This happens when a project card is organization wide
@wolfy1339
fix: add missing internal value to repository visibility field
5309b15
@wolfy1339
style: run prettier
4cdacc6
@wolfy1339
feat: visibility is required field on repository
f03e1ba
@wolfy1339
feat: updated example payloads for visibility field
c0481c6
@wolfy1339
fix: check_suite#after can be null
2281de8
@wolfy1339
fix: add missing branch_protection_rule event to App
4aa1c44
@wolfy1339
feat: new run_attempt property on workflow_job
d87756f
@wolfy1339
build: generate types
37f04b2
@wolfy1339
feat: update workflow_job example payloads
145fb4e
@wolfy1339
fix: correct typo in enum for App key permission enum
de51a73
@wolfy1339
feat: new allow_update_branch property on Repository
cb9d085
@wolfy1339
feat: new draft property on issue object
2dc3e74
@wolfy1339
feat: update payloads for new draft property
57c059d
G-Rath
G-Rath approved these changes Nov 22, 2021
View reviewed changes
Copy link
Member

@G-Rath G-Rath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, but hard to review in detail because of the size - if you can be bothered it could be good to break out into smaller PRs? e.g. topics on repositories can definitely be landed I think.

@wolfy1339
Copy link
Member Author

This looks fine to me, but hard to review in detail because of the size - if you can be bothered it could be good to break out into smaller PRs? e.g. topics on repositories can definitely be landed I think.

Even splitting it wouldn't really help with the size of the PR that much, as there's updates to almost every payload due to new required properties in the repository schema.

@wolfy1339 wolfy1339 merged commit d99b9a7 into master Nov 22, 2021
@wolfy1339 wolfy1339 deleted the schema-updates branch November 22, 2021 03:25
@octokitbot
Copy link
Collaborator

🎉 This PR is included in version 4.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

wolfy1339 added a commit that referenced this pull request Nov 23, 2021
@wolfy1339
fix: update payloads for #576
bd724bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdatdo0601 bdatdo0601 bdatdo0601 approved these changes

@G-Rath G-Rath G-Rath approved these changes

Assignees
No one assigned
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wolfy1339 @octokitbot @G-Rath @bdatdo0601