Feature: Options Parameter #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inserted the option to select consistent dimension for short-ids Also inserted an option to remove repeated characters in alphabets
|
I'm not sure about the prevent repeat behavior. Unlike the padding, it creates a condition where two instances may translate something differently. I would be more inclined to have the library throw an error if you try to use an alphabet with repeating characters without setting an explicit repeat flag rather than have it silently change the alphabet. |
The code will not silently change the alphabet Now invalid inputs will throw an Error
oculus42
approved these changes
Sep 6, 2020
|
Because it's irrevocably ES6, I'm going to go ahead and convert the rest before publishing a 4.0.0 version, but am working on it right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following Issue #39
Inserted the option to select consistent dimension for short-ids
Also inserted an option to remove repeated characters in alphabets
Way better than my last Pull Request, now you can choose to have Consistent Length or not, leaving the original flow unchanged.
If you find anything wrong, please let me know.