update the publish workflow to also build and publish dracon itself a… #185
Conversation
deploy/dracon/chart/Chart.yaml
Outdated
| @@ -4,7 +4,6 @@ description: | | |||
| A Helm chart for Kubernetes containing services needed for Dracon pipelines to run. Please check the documentation for more information | |||
| type: application | |||
| version: 0.7.0 | |||
There was a problem hiding this comment.
since you removed the appVersion you can remove the version field too
There was a problem hiding this comment.
every helm chart needs a version, can't remove it
There was a problem hiding this comment.
you can pass the version as a parameter when building the chart same way you do for the appVersion
northdpole
force-pushed
the
improve-publish-action
branch
2 times, most recently
from
445d024
to
4df7507
Compare
| set -e | ||
| DRACON_VERSION_SEMVER=$(sed 's/v//' <<< ${{ github.ref_name }}) | ||
|
|
||
| go install github.com/ocurity/dracon/cmd/draconctl@latest |
There was a problem hiding this comment.
why do this? you already checked out the latest version of the codebase and you are executing commands in it
There was a problem hiding this comment.
it's a matter of principle:
in this scope draconctl is a tool used to package and publish things, hence we use the latest stable version
if we were to be testing draconctl then we can build it from the binary
i don't see how this is a problem
There was a problem hiding this comment.
you are not using the latest stable version, you are using the latest commit in the main branch. these are not the same unfortunately
.github/workflows/publish.yml
Outdated
| go install github.com/ocurity/dracon/cmd/draconctl@latest | ||
| ~/go/bin/draconctl components package --version ${{ github.ref_name }} --chart-version ${DRACON_VERSION_SEMVER} --name dracon-oss-components ./components; | ||
|
|
||
| helm package --version=${DRACON_VERSION_SEMVER} --app-version=${DRACON_VERSION_SEMVER} deploy/dracon/chart |
There was a problem hiding this comment.
the --app-version should be set to ${{ github.ref_name }} in the same way as it is in the previous command so that we can reference the original tag of the git repo
Makefile
Outdated
| @@ -211,6 +213,7 @@ dev-dracon: deploy-elasticoperator deploy-arangodb-crds add-bitnami-repo | |||
| --values ./deploy/dracon/values/dev.yaml \ | |||
| --create-namespace \ | |||
| --namespace $(DRACON_NS) \ | |||
| --version $$(echo "${DRACON_VERSION}" | sed 's/^v//') | |||
There was a problem hiding this comment.
the line has a different format than the rest of the command and it's missing a slash at the end. there is a small bug at the next line that's also missing a slash at the end, unrelated to this PR but I think we should fix it since we are working here.
deploy/dracon/chart/values.yaml
Outdated
| @@ -64,7 +64,14 @@ enrichmentDB: | |||
| # enrichment database | |||
| connectionStr: "" | |||
|
|
|||
| dracon-components: | |||
There was a problem hiding this comment.
I don't see any change in the Helm manifests where this is used. why is it here?
deploy/dracon/chart/values.yaml
Outdated
| global: | ||
| image: | ||
| # registry to use for all | ||
| registry: "" | ||
| registry: "ghcr.io" |
There was a problem hiding this comment.
all our images already have a default value for the registry in the Helm template, I don't think we need this here or if we put it here, we should remove the use of the default function in the Helm templates
deploy/dracon/chart/Chart.yaml
Outdated
| @@ -13,4 +11,4 @@ dependencies: | |||
| - name: mongodb | |||
| version: 15.1.5 | |||
| repository: https://charts.bitnami.com/bitnami | |||
| condition: mongodb.enabled | |||
| condition: mongodb.enabled | |||
There was a problem hiding this comment.
why remove the last line?
northdpole
force-pushed
the
improve-publish-action
branch
from
bd104cd
to
3c02e34
Compare
northdpole
force-pushed
the
improve-publish-action
branch
from
c024911
to
ba945c6
Compare
…nd draconctl
closes #186