Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

considers token expiration time for submitted email #312

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

burnout87
Copy link
Collaborator

No description provided.

@burnout87 burnout87 self-assigned this Dec 10, 2021
@burnout87 burnout87 added the enhancement New feature or request label Dec 10, 2021
@burnout87 burnout87 linked an issue Dec 10, 2021 that may be closed by this pull request
@burnout87 burnout87 added this to the v21.10.0004 milestone Dec 10, 2021
@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #312 (2f6b491) into master (b83f948) will increase coverage by 6.05%.
The diff coverage is n/a.

❗ Current head 2f6b491 differs from pull request most recent head 33654b4. Consider uploading reports for the commit 33654b4 to get more accurate results

@@            Coverage Diff             @@
##           master     #312      +/-   ##
==========================================
+ Coverage   61.29%   67.35%   +6.05%     
==========================================
  Files          41       38       -3     
  Lines        6341     5293    -1048     
==========================================
- Hits         3887     3565     -322     
+ Misses       2454     1728     -726     
Impacted Files Coverage Δ
cdci_data_analysis/analysis/json.py 60.00% <0.00%> (-15.00%) ⬇️
...plugins/dummy_instrument/data_server_dispatcher.py 89.01% <0.00%> (-1.23%) ⬇️
cdci_data_analysis/configurer.py 84.75% <0.00%> (-1.04%) ⬇️
cdci_data_analysis/analysis/parameters.py 81.20% <0.00%> (-0.58%) ⬇️
cdci_data_analysis/analysis/queries.py 55.37% <0.00%> (-0.40%) ⬇️
cdci_data_analysis/flask_app/dispatcher_query.py 74.20% <0.00%> (-0.10%) ⬇️
...lysis/plugins/dummy_instrument/empty_instrument.py 100.00% <0.00%> (ø)
...lask_app/templates/body_article_product_gallery.py
cdci_data_analysis/analysis/drupal_helper.py
cdci_data_analysis/analysis/renku_helper.py
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b83f948...33654b4. Read the comment docs.

@burnout87
Copy link
Collaborator Author

burnout87 commented Dec 10, 2021

@volodymyrss do you think this criteria to evaluate whether or not an additional submitted email should be sent make sense?

time_from_last_submitted_email > min(time_to_token_expiration, email_sending_job_submitted_interval)

@volodymyrss volodymyrss modified the milestones: v21.10.0004, v22.01.0001 Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider also token expiration time for send submitted email
2 participants