Adapt to new dummy instrument #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #224 +/- ##
==========================================
+ Coverage 57.55% 57.71% +0.15%
==========================================
Files 22 22
Lines 4686 4687 +1
==========================================
+ Hits 2697 2705 +8
+ Misses 1989 1982 -7 ☔ View full report in Codecov by Sentry. |
|
This is to address the missing dummy instrument introduced with oda-hub/dispatcher-app#601 |
|
I removed that part in the test |
volodymyrss
reviewed
Nov 20, 2023
volodymyrss
approved these changes
Nov 20, 2023
|
It looks I am not authorized to merge. I was until the last PR... @volodymyrss |
|
Hm I was changing some settings to enable this version bump, I will look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.