-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
secret access API added based on renku secrets implementation #271
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #271 +/- ##
===========================================
- Coverage 59.00% 19.14% -39.87%
===========================================
Files 23 25 +2
Lines 4945 4963 +18
===========================================
- Hits 2918 950 -1968
- Misses 2027 4013 +1986 ☔ View full report in Codecov by Sentry. |
Thanks! There is readthedocs in this repo, could you add a section there? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Please add a doc?
Note that this PR is already published in docs at https://odahub.io/docs/guide-development/ Please merge it ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Static type checking fails, preventing unit tests from starting. Proposed changes should fix it.
Live API tests issue is most likely on the production instance side. |
Co-authored-by: Denys Savchenko <56398430+dsavchenko@users.noreply.github.com>
Co-authored-by: Denys Savchenko <56398430+dsavchenko@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please fix the MyPy check?
No description provided.