Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

not masked ODAHUFLOWCTL_OAUTH_CLIENT_SECRET configuration variable value #307

Closed
BPylypenko opened this issue Aug 7, 2020 · 0 comments · Fixed by #373
Closed

not masked ODAHUFLOWCTL_OAUTH_CLIENT_SECRET configuration variable value #307

BPylypenko opened this issue Aug 7, 2020 · 0 comments · Fixed by #373
Assignees
@keshamin
Labels
1.3 bug Something isn't working minor not directly related to functionality and data. No workarounds are needed to complete the action

Comments

@BPylypenko
Copy link
Contributor

Prerequisite
installed odahuflowctl

To Reproduce
Steps to reproduce the behavior:

  1. login through odahuflowctl by using --url, --client_id, --client_secret, --issuer flags
  2. type odahuflowctl config all
  3. and you can see that ODAHUFLOWCTL_OAUTH_CLIENT_SECRET value is not masked

Expected behavior
ODAHUFLOWCTL_OAUTH_CLIENT_SECRET variable value should be masked

Actual behavior
ODAHUFLOWCTL_OAUTH_CLIENT_SECRET variable value is not masked

Environment:

  • OS: macOS 10.15.5
  • cli, sdk versions: 1.2.0-rc7
@BPylypenko BPylypenko added bug Something isn't working minor not directly related to functionality and data. No workarounds are needed to complete the action labels Aug 7, 2020
@BPylypenko BPylypenko added the 1.3 label Sep 25, 2020
@keshamin keshamin mentioned this issue Sep 25, 2020
Merged
@keshamin keshamin linked a pull request Sep 25, 2020 that will close this issue
[#307] Mask client secret in CLI config #373
Merged
@keshamin keshamin self-assigned this Sep 25, 2020
keshamin added a commit that referenced this issue Sep 28, 2020
@keshamin
[#307] Mask client secret in CLI config (#373)
f40bd7a 
Mask ODAHUFLOWCTL_OAUTH_CLIENT_SECRET (and other properties ending with _SECRET as well) in output of `odahuflowctl config all`.
keshamin added a commit that referenced this issue Sep 28, 2020
@keshamin
[#307] Mask client secret in CLI config (#373)
bfe6eb6 
Mask ODAHUFLOWCTL_OAUTH_CLIENT_SECRET (and other properties ending with _SECRET as well) in output of `odahuflowctl config all`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keshamin keshamin

Labels
1.3 bug Something isn't working minor not directly related to functionality and data. No workarounds are needed to complete the action
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#307] Mask client secret in CLI config odahu/odahu-flow
2 participants
@keshamin @BPylypenko