Adding a demofilter #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing. If splitnetdemos was enabled when the autorecording was previously enabled, it properly disables it.
|
Also, here's a screenshot of how it looks ingame. |
|
The problem, is that I first planned a byte system, but it'd be absolutely messy for the player if modifying from the .cfg . Individual CVARs were far easier to manage in case of a problem though. |
nstlaurent
requested changes
Mar 27, 2019
| @@ -216,6 +226,11 @@ value_t OnOffAuto[3] = { | |||
| { 2.0, "Auto" } | |||
| }; | |||
|
|
|||
| value_t DemoRestrictions[2] = { | |||
There was a problem hiding this comment.
Whys is 0 allow and 1 restrict? This is OK as far as setting in the application. This is confusing in odamex.cfg because having cl_autorecord_filter_duel set to 1 would imply that it would record but it's the opposite.
To me it seems we should flip the DemoRestrictions values and default the cvar to 1.
…ofilter # Conflicts: # client/src/m_options.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested by the community, to be able not to record everything from every gamemode.
I also added these options under the "Network options" submenu.