-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring back the classic intermission screen to Odamex. #440
Conversation
Is there an elegant way we can include the player names in this scenario? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from my notes, I actually like the idea that @rakohus had. Would it be possible to just print the name in either smallfont or digfont above or below each player? I feel that would preserve some of the usefulness of the screen.
//else | ||
WI_drawDeathmatchStats(); | ||
if (demoplayback) | ||
WI_drawNetgameStats(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer it if either both parts of an if
statement have braces or neither.
@@ -180,7 +180,7 @@ CVAR_RANGE_FUNC_DECL(msgmidcolor, "5", "Color used for centered messages.", | |||
// ------------ | |||
|
|||
// Determines whether to draw the scores on intermission. | |||
CVAR( wi_newintermission, "0", "Draw the scores on intermission", | |||
CVAR( wi_newintermission, "0", "Use Odamex's intermission screen if there are 4 players or less on cooperative gamemodes.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a convenient place to slot this into the menu system?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was done originally with #80 but I rewrote it since it broke compilation with no apparent reason.
This commits reenables
wi_newintermission
's original functionality that was disabled long ago.It also partially fixes coop movies that were desynced due to Odamex's intermission's timer method.
Also, it is disabled automatically whenever 5+ players are playing at the same time online.
COOP demo:
Online: