Bring back the classic intermission screen to Odamex. #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there an elegant way we can include the player names in this scenario? |
AlexMax
requested changes
Jul 31, 2021
There was a problem hiding this comment.
Aside from my notes, I actually like the idea that @rakohus had. Would it be possible to just print the name in either smallfont or digfont above or below each player? I feel that would preserve some of the usefulness of the screen.
| //else | ||
| WI_drawDeathmatchStats(); | ||
| if (demoplayback) | ||
| WI_drawNetgameStats(); |
There was a problem hiding this comment.
I'd prefer it if either both parts of an if statement have braces or neither.
| @@ -180,7 +180,7 @@ CVAR_RANGE_FUNC_DECL(msgmidcolor, "5", "Color used for centered messages.", | |||
| // ------------ | |||
|
|
|||
| // Determines whether to draw the scores on intermission. | |||
| CVAR( wi_newintermission, "0", "Draw the scores on intermission", | |||
| CVAR( wi_newintermission, "0", "Use Odamex's intermission screen if there are 4 players or less on cooperative gamemodes.", | |||
There was a problem hiding this comment.
Is there a convenient place to slot this into the menu system?
There was a problem hiding this comment.
It's already there for years... It just was left for many releases.
|
Current status online looks like this.
|
AlexMax
approved these changes
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was done originally with #80 but I rewrote it since it broke compilation with no apparent reason.
This commits reenables
wi_newintermission's original functionality that was disabled long ago.It also partially fixes coop movies that were desynced due to Odamex's intermission's timer method.
Also, it is disabled automatically whenever 5+ players are playing at the same time online.
COOP demo:
Online:
